Fix STM32H7 dual core inheritance again #366
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Noticed that the website generator CI job was printing some warnings about overriding some attributes that didn't exist and then dying with a foreign key error. Oops!
Turns out that I kinda messed up in my attempt to refactor these STM32H7 targets. Not only were there some typos, which weren't caught by the testing I did but were caught by the website generator, but also the inheritance order is backwards from how I expected it: the first target in the list of parent targets gets the highest "priority" and can override the attributes from the other targets. Interestingly, this is actually documented in the code if you know where to look.
To fix this, I swapped the "inherits" order and made the CM4/CM7 targets not inherit from any other targets, which should fix the issue by making sure that they have priority to override stuff from the base MCU targets.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results